-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SetDutyCycle
mock
#88
Conversation
f935771
to
f09123c
Compare
it seems that the format of the assertion message is now different in nightly? i.e. the failure seems to be unrelated...
(however, i have the very odd experience that without my PR it builds fine locally but with it it also fails with |
Yeah, nightly apparently changed the assertion format. If we adapt to nightly, then tests on stable will fail. I think I'll simply reduce the assertions to a smaller subset of the message. |
@rursprung should be fixed on |
f09123c
to
eb02fe9
Compare
rebased, works fine now. thanks for fixing this! |
eb02fe9
to
f5b3a2c
Compare
@dbrgn: while it wasn't strictly necessary (would've merged just fine also without this) i've now rebased this on top of the latest thanks for your work on this crate! |
f5b3a2c
to
69d3d82
Compare
thanks for all your feedback @dbrgn, i've incorporated it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Released in 0.10.0-rc.2. |
this is the 1.0 equivalent of the old
PwmPin
trait (the mock for this has been added in #52).note that the test coverage is fully handled by the doc test which is why there's no additional
mod test
in this file.this fixes #73
(note: this replaces #74 which was targeting the now defunct
1-alpha
branch)