Migrate from os.rename to shutil.move
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.rename` is brittle and prone to failure. Among other things, it struggles with moving files between mount points. Something that's required if you have docker volumes. Should also address dbr#154
|
Thanks for the pull request! This seems like a good change. I think this obsoletes the is_same_partition code and accompanying logic - would you have the time to look at removing that also in this PR? (writing from a phone, so excuse the short explanation - let me know if it's unclear what I'm describing!) |
|
@dbr I've removed the partition check. Looks like there are some flakey tests. Unexpected show returns from TVDB. Not sure if it's region related. |
|
Sorry for the delay - cool, these changes look good to me. Thanks! As you say, the tests failing are due to flakeyness with the tests using live data (e.g one of the tests was relying on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.renameis brittle and prone to failure. Among other things, it struggles with moving files between mount points. Something that's required if you have docker volumes.See article for more info
https://giedrius.blog/2018/01/28/why-os-move-sometimes-does-not-work-and-why-shutil-move-is-the-savior/
Should also address #154