Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recover index command and change recover new function #572

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Jul 22, 2023


PR-Codex overview

This PR focuses on adding a new test case for the test_test_data_index_node_setup function.

Detailed summary

  • Added a new test case for test_test_data_index_node_setup in the system_sdk.rs file.
  • Created a new module node_test_base in the node_test_base.rs file.
  • Added a new import for NodeTestBase in the rollup_executor.rs file.

The following files were skipped due to too many changes: src/node/src/rollup_executor.rs, src/node/src/node_test_base.rs, src/node/src/recover.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #572 (2776ba2) into main (a988a47) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   63.97%   63.97%           
=======================================
  Files           9        9           
  Lines         433      433           
  Branches       64       64           
=======================================
  Hits          277      277           
  Misses        156      156           
Flag Coverage Δ
rust 63.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imotai
Copy link
Contributor

imotai commented Jul 23, 2023

I want the following command usage

db3 recover rollup 

and

db3 recover index

not the db3 recover-index

@jingchen2222
Copy link
Collaborator Author

I want the following command usage

db3 recover rollup 

and

db3 recover index

not the db3 recover-index

resolved in latest pr.

Will implement recover rollup in the next pr.

@imotai imotai merged commit c0fd30b into main Jul 24, 2023
@imotai imotai deleted the feat/recover_cmd branch July 24, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants