Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for upload ut #562

Merged
merged 11 commits into from
Jul 18, 2023
Merged

add unit test for upload ut #562

merged 11 commits into from
Jul 18, 2023

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Jul 13, 2023


PR-Codex overview

This PR focuses on adding new features and making improvements to the codebase.

Detailed summary

  • Added balance logging in upload_file function in ar_fs.rs
  • Modified the default values for network_id and chain_id in command.rs
  • Modified the default values for network_id and chain_id in DB3Command enum in command.rs
  • Added chain_id parameter to various functions in DB3Command implementation
  • Added chain_id parameter to various functions in StorageNodeV2Config and StorageNodeV2Impl structs in storage_node_light_impl.rs
  • Added chain_id parameter to various functions in RollupExecutor struct in rollup_executor.rs
  • Added chain_id parameter to various functions in Recover struct in recover.rs
  • Added new functions for testing in ar_fs.rs

The following files were skipped due to too many changes: src/node/src/recover.rs, src/storage/src/meta_store_client.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jingchen2222 jingchen2222 requested a review from imotai July 13, 2023 04:30
@jingchen2222 jingchen2222 self-assigned this Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #562 (b3befe7) into main (e7aca6d) will increase coverage by 0.00%.
The diff coverage is 41.86%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main     #562    +/-   ##
========================================
  Coverage   53.88%   53.88%            
========================================
  Files          37       37            
  Lines        6416     6566   +150     
  Branches       61       61            
========================================
+ Hits         3457     3538    +81     
- Misses       2959     3028    +69     
Flag Coverage Δ
rust 53.88% <41.86%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/node/src/ar_toolbox.rs 77.36% <0.00%> (-0.36%) ⬇️
src/node/src/command.rs 0.00% <0.00%> (ø)
src/node/src/recover.rs 0.00% <0.00%> (ø)
src/storage/src/meta_store_client.rs 16.76% <30.15%> (+8.28%) ⬆️
src/node/src/rollup_executor.rs 29.78% <50.00%> (+0.47%) ⬆️
src/storage/src/ar_fs.rs 56.77% <65.21%> (+10.07%) ⬆️
src/node/src/storage_node_light_impl.rs 36.11% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@imotai imotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotai imotai merged commit 4891f88 into main Jul 18, 2023
@imotai imotai deleted the feat/add_upload_ut branch July 24, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants