Skip to content

Conversation

@nilesh-c
Copy link
Member

I did a mvn clean install and compared the diff of the original vs changed version, with the liwiki dump. Outputs are matching.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could remove {File,FileOutputStream, here

@nilesh-c
Copy link
Member Author

@jcsahnwaldt removed the imports; made the FileLike JavaDoc change here too.

jimkont added a commit that referenced this pull request Jun 18, 2014
Make MarkerDestination work with FileLike instead of File
@jimkont jimkont merged commit 3792915 into dbpedia:master Jun 18, 2014
@nilesh-c nilesh-c deleted the markerdestination branch June 18, 2014 16:59
@jcsahnwaldt
Copy link
Contributor

Nice! Thanks, @nilesh-c !

@nilesh-c
Copy link
Member Author

@jcsahnwaldt no problem. :)

@jimkont jimkont modified the milestone: pastReleases Mar 19, 2015
jimkont added a commit to jimkont/extraction-framework that referenced this pull request Mar 26, 2015
Make MarkerDestination work with FileLike instead of File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants