Convert all File stuff to Path; add fallback to Config from DistConfig when required #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done to convert all remaining
File-specific stuff to usingPath. That is necessary because we have to support Hadoop file systems (HDFS etc.) equally well - already discussed.As for this particular change, I personally feel this is getting pretty ugly because the client code is having to juggle between DistConfig and Config when it comes to dealing with
mappingsDir, 'ontologyFileanddumpDir`. But this is supposed to be handled behind-the-scenes by the config object.I propose to reject this PR and combine Config and DistConfig into one single DistConfig. I'll make a new PR. Here's how DistConfig will look like: