Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

Feature(Carousel): top section for carousel now can be styled #1311

Merged
merged 4 commits into from
Jul 15, 2019

Conversation

BazanAlexandro
Copy link
Contributor

Please tick a box

  • feature (A new feature)
  • fix (A bug fix)
  • refactor (A code change that neither fixes a bug nor adds a feature)
  • docs (Documentation only changes)
  • performance (A code change that improves performance)
  • style (Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • build (Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm))
  • ci (Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs))
  • test (Adding missing tests or correcting existing tests)

If you're adding a feature, is it documented in a storybook story?

  • Yes
  • No
  • Not adding a new feature

Are the components you're working on reusable between brands?

  • Yes (Using variables that are defined in the default theme)
  • No (I hard coded some values)
  • Not working on any components

If you're creating markup, did you add proper semantics?

(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)

Copy link
Contributor

@misund misund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@misund misund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BazanAlexandro BazanAlexandro merged commit 974ca8c into master Jul 15, 2019
@BazanAlexandro BazanAlexandro deleted the feature/styled-carousel branch July 15, 2019 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants