Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

feature(themes): Add future theme #1123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

misund
Copy link
Contributor

@misund misund commented Apr 12, 2019

Use this PR as a reference for how to add a new theme.

Please tick a box

  • feature (A new feature)
  • fix (A bug fix)
  • refactor (A code change that neither fixes a bug nor adds a feature)
  • docs (Documentation only changes)
  • performance (A code change that improves performance)
  • style (Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • build (Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm))
  • ci (Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs))
  • test (Adding missing tests or correcting existing tests)

If you're adding a feature, is it documented in a storybook story?

  • Yes
  • No
  • Not adding a new feature

Are the components you're working on reusable between brands?

  • Yes (Using variables that are defined in the default theme)
  • No (I hard coded some values)
  • Not working on any components

If you're creating markup, did you add proper semantics?

(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants