Feat element relation view #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of elkjs limitations edge labels cannot be displayed properly at this point without sacrificing the desired layout. Edge labels will be omitted completely as to not create confusion with them showing up on the top left corner. They should be added back when the issues with the edge labels got fixed.
huyenngn
force-pushed
the
feat-element-relation-view
branch
from
563d5e5 to
88e15a1
Compare
ewuerger
requested changes
Aug 7, 2024
Collaborator
There was a problem hiding this comment.
Good job. I am not sure about the naming of this View. We bring ExchangeItems and Classes with ExchangeItemElements into a relation. But we also reuse the ClassTreeView. Maybe ExchangeItemClassTreeView? I am open for ideas.
Never the less, we need documentation here:
- Add a exchange_item_class_tree_view.md in docs (add it to mkdocs.yml)
- Hint to the problem of routing edges (
ExchangeItemElements) which could be solved when Libavoid comes publically available
- Hint to the problem of routing edges (
- Describe collection, parameters and give examples (reuse the test case)
- Add the needed SVGs to the docs/gen_images.py
capellambse_context_diagrams/collectors/element_relation_view.py
Outdated
Show resolved
Hide resolved
capellambse_context_diagrams/collectors/element_relation_view.py
Outdated
Show resolved
Hide resolved
capellambse_context_diagrams/collectors/element_relation_view.py
Outdated
Show resolved
Hide resolved
capellambse_context_diagrams/collectors/element_relation_view.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Ernst Würger <[email protected]>
huyenngn
force-pushed
the
feat-element-relation-view
branch
3 times, most recently
from
5c4fab9 to
0338310
Compare
huyenngn
force-pushed
the
feat-element-relation-view
branch
from
0338310 to
84ebc9a
Compare
ewuerger
requested changes
Aug 20, 2024
Collaborator
ewuerger
left a comment
ewuerger
left a comment
There was a problem hiding this comment.
Just rename it back to exchange_item_relation_view.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.