Skip to content

fix(settings): hide Guest links without T3 Connect #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbalders merged 2 commits into from
Nov 2, 2026
Merged

fix(settings): hide Guest links without T3 Connect #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a5a98
fix(settings): hide guest links without T3 Connect
dbalders Nov 2, 2026
2a360a1
test(usage): pin saved-history retention clock
dbalders Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/server/src/usage/UsageService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2450,8 +2450,9 @@ describe("UsageService", () => {
}).pipe(Effect.scoped),
);

it.live("reports saved usage of a removed directory only for windows it reaches", () =>
it.effect("reports saved usage of a removed directory only for windows it reaches", () =>
Effect.gen(function* () {
yield* TestClock.setTime(Date.parse("2026-08-02T12:00:00Z"));
const { transcript, settings, home } = yield* setup;
yield* Effect.promise(async () => {
await NodeFSP.writeFile(transcript, claudeLine(1, 5));
Expand Down
9 changes: 5 additions & 4 deletions apps/web/src/components/settings/LabsSettingsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ import { useScopedSettings, useUpdateScopedSettings } from "./useScopedSettings"
export function LabsSettingsPanel() {
return (
<SettingsPageContainer>
<SettingsSection id="beta" title="Beta">
{/* Clerk is only mounted when this build has T3 Connect. */}
{hasCloudPublicConfig() ? <GuestLinksRowWithSignIn /> : <GuestLinksRow />}
</SettingsSection>
{hasCloudPublicConfig() ? (
<SettingsSection id="beta" title="Beta">
<GuestLinksRowWithSignIn />
</SettingsSection>
) : null}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
{isFeatureAvailable("guidedTour") ? <ExperimentalFeaturesSection /> : null}
<LegacyFeaturesSection />
</SettingsPageContainer>
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/components/settings/settingsSearch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ describe("searchSettings", () => {
"review-guide-instructions",
"source-control-writing-style",
"t3-connect",
"guest-links",
"hold-webhooks-while-offline",
"tailscale-https",
"wsl-backend",
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/components/settings/settingsSearchCatalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ export const SETTINGS_SEARCH_ITEMS = [
id: "guest-links",
title: "Guest links",
to: "/settings/labs",
cloudOnly: true,
scope: "environment",
searchTerms: ["beta share guest invite link teammate watch t3 connect tunnel"],
},
Expand Down
Loading