Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating fork #4

Merged
merged 9 commits into from
Aug 24, 2019
Merged

Updating fork #4

merged 9 commits into from
Aug 24, 2019

Conversation

dbaduck
Copy link
Owner

@dbaduck dbaduck commented Aug 24, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Approach

Commands to test

Screenshots

Learning

sanderstad and others added 9 commits August 19, 2019 16:13
* Improved regex

* Added verbose messages
Removed geometry
Removed duplicate checks

* Added check

* Moved check

* Removed commented code

* Fixed check for data type
Changed PII Name

* Fixed test

* Added masking type and subtype

* Moved to better way of getting masking types

* Fixed masking command to use patterns

* Added extra items
Improved regexes

* Removed commented code

* Removed file

* Added masking type

* Changed object to check for

* Changed if to for loop

* Removed redundant code

* Changed the way the command returns the results

* Implemented search array
Removed for loop

* Removed debug messages

* Fixed random string creation

* Changed check for patterns

* Added parameter to help

* Fixed checks for integers

* Fixed max values for integers

* Fixed masking type for creditcard

* Added data type

* Added website and credit card cvv

* Added smallint

* Added characterstring parameter
Changed assignment of minValue and maxValue
Removed debug message
Moved  setting of min and ma values
Changed assignment of char string in object

* Removed debug message

* Added parameters to help
Renamed parameters

* Added file back that is used with another function

* Fixed test

* Fixed test

* Fixed tests

* Split up know name patterns

* Removed result array
Added candidate found flag
Fixed duplicate results
Removed commented code

* Added extra check for already present result

* Fixed test
* Initial version Add-DbaRoleMember

* add command to export

* fix bug found with test

* initial test (it will fail)

* Updating examples

* Adding property to Get-DbaServerRole

* Adjusting output of New-DbaServerRole

* Rename to Add-DbaServerRoleMember

* update function name

* Update test file name (do Add-DbaServerRoleMember)

* formatting

* fixed bug New-DbaServerRole

* Addressing piping support from Get

* adding command to psm1 for Linux support

* add property to test Get-DbaServerRole

* fix formatter validation

* updating DbRoleMember test to use generated users

* expanded example for Azure SQL

* removed example for Azure SQL, confirmed it does not work
* test a test

* maybe this

* sup

* fully qualify

* remove upload

* wonder if this works

* that didnt work

* run a command

* that didnt work

* fix words
@dbaduck dbaduck merged commit c841c94 into dbaduck:development Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants