Skip to content

refactor(button): enabled the disabled styling #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfranzke merged 1 commit into from
Aug 6, 2025
Merged

refactor(button): enabled the disabled styling #4686

mfranzke merged 1 commit into from
Aug 6, 2025

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 6, 2025

Proposed changes

Even also enabled the disabled styling on an aria-disabled button.

Resolves #4680

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor(button): enabled the disabled styling
e77e65b 
Even also enabled the disabled styling on an aria disabled button.
@mfranzke mfranzke requested a review from nmerget as a code owner August 6, 2025 08:36
@mfranzke mfranzke linked an issue Aug 6, 2025 that may be closed by this pull request
describedbyid is reported as non existent on DBButton #4680
Closed
7 tasks
@mfranzke mfranzke self-assigned this Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4680-describedbyid-is-reported-as-non-existent-on-dbbutton

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Aug 6, 2025
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Aug 6, 2025
@mfranzke mfranzke enabled auto-merge (squash) August 6, 2025 08:36
@mfranzke mfranzke disabled auto-merge August 6, 2025 08:50
@mfranzke mfranzke merged commit 0b7c25d into main Aug 6, 2025
56 checks passed
@mfranzke mfranzke deleted the 4680-describedbyid-is-reported-as-non-existent-on-dbbutton branch August 6, 2025 08:51
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget

Assignees

@mfranzke mfranzke

Labels

🍄🆙improvement New feature or request

Projects

UX Engineering Team Backlog
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

describedbyid is reported as non existent on DBButton

2 participants

@mfranzke