Skip to content

fix: issue with popover & tooltip using it in pure html css #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmerget merged 3 commits into from
Jun 11, 2025
Merged

fix: issue with popover & tooltip using it in pure html css #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfc76ad
fix: issue with popover & tooltip using it in pure html css
nmerget Jun 11, 2025
299ab3c
chore: update snapshots
nmerget Jun 11, 2025
f79b7b2
Merge branch 'main' into fix-pure-css-popover
nmerget Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...s__/popover/component/chromium/DBPopover-after-open-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts__/popover/component/firefox/DBPopover-after-open-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...opover/component/mobile-chrome/DBPopover-after-open-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
154 changes: 46 additions & 108 deletions packages/components/src/components/popover/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,113 +7,51 @@
</head>
<body style="padding: var(--db-spacing-fixed-md)">
<h2>Default</h2>
<button class="db-button" aria-describedby="popover-01">
Popover bottom
<i class="db-popover" id="popover-01">Test</i>
</button>
<button class="db-button" aria-describedby="popover-02">
Popover top
<i class="db-popover" data-placement="top" id="popover-02">Test</i>
</button>
<button class="db-button" aria-describedby="popover-03">
Popover left
<i class="db-popover" data-placement="left" id="popover-03">Test</i>
</button>
<button class="db-button" aria-describedby="popover-04">
Popover right
<i class="db-popover" data-placement="right" id="popover-04"
>Test</i
>
</button>

<h2>Gap</h2>
<button class="db-button" aria-describedby="popover-05">
Popover bottom gap
<i class="db-popover" data-gap="true" id="popover-05">Test</i>
</button>
<button class="db-button" aria-describedby="popover-06">
Popover top gap
<i
class="db-popover"
data-placement="top"
data-gap="true"
id="popover-06"
>
Test
</i>
</button>
<button class="db-button" aria-describedby="popover-07">
Popover left gap
<i
class="db-popover"
data-placement="left"
data-gap="true"
id="popover-07"
>
Test
</i>
</button>
<button class="db-button" aria-describedby="popover-08">
Popover right gap
<i
class="db-popover"
data-placement="right"
data-gap="true"
id="popover-08"
>
Test
</i>
</button>

<h2>Animation/delay</h2>

<button class="db-button" aria-describedby="popover-09">
Popover delay slow
<i class="db-popover" data-delay="slow" id="popover-09">Test</i>
</button>

<button class="db-button" aria-describedby="popover-10">
Popover delay fast
<i class="db-popover" data-delay="fast" id="popover-10">Test</i>
</button>

<button class="db-button" aria-describedby="popover-11">
Popover plain
<i class="db-popover" data-behavior="plain" id="popover-11">Test</i>
</button>

<h2>Width</h2>

<button class="db-button" aria-describedby="popover-12">
Popover auto width
<i class="db-popover" id="popover-12">
Max width, lorem ipsum dolor sit amet, consetetur sadipscing
</i>
</button>

<button class="db-button" aria-describedby="popover-13">
Popover fixed width
<i class="db-popover" data-width="fixed" id="popover-13">
Max width, lorem ipsum dolor sit amet, consetetur sadipscing
</i>
</button>

<button class="db-button" aria-describedby="popover-14">
Popover test
<i class="db-popover" data-placement="top" id="popover-14">
<h4>Title</h4>
<p>Paragraph</p>
<a href="#">Link</a>
</i>
</button>

<button class="db-button" aria-describedby="popover-15">
Popover open
<i class="db-popover" data-open="true" id="popover-15">
<h4>Title</h4>
<p>Paragraph</p>
<a href="#">Link</a>
</i>
</button>
<div class="db-stack" data-direction="row" style="overflow: unset">
<div id="popover-00" class="db-popover">
<button class="db-button" type="button">right</button>
<article
class="db-popover-content"
data-placement="right"
data-animation="true"
>
<button class="db-button" type="button">
Inside Popover
</button>
</article>
</div>
<div id="popover-01" class="db-popover">
<button class="db-button" type="button">bottom</button>
<article class="db-popover-content" data-animation="true">
<button class="db-button" type="button">
Inside Popover
</button>
</article>
</div>
<div id="popover-02" class="db-popover">
<button class="db-button" type="button">top</button>
<article
class="db-popover-content"
data-placement="top"
data-animation="true"
>
<button class="db-button" type="button">
Inside Popover
</button>
</article>
</div>
<div id="popover-02" class="db-popover">
<button class="db-button" type="button">left</button>
<article
class="db-popover-content"
data-placement="left"
data-animation="true"
>
<button class="db-button" type="button">
Inside Popover
</button>
</article>
</div>
</div>
</body>
</html>
2 changes: 2 additions & 0 deletions packages/components/src/components/popover/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
.db-popover {
position: relative;
display: flex;
block-size: fit-content;
inline-size: fit-content;

&:is([data-e2e-hover="true"], :hover, :focus-within) {
> article:not([data-open="false"]) {
Expand Down
30 changes: 25 additions & 5 deletions packages/components/src/components/tooltip/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,45 @@
</head>
<body style="padding: var(--db-spacing-fixed-md)">
<h1>Placement</h1>
<button class="db-button" aria-describedby="tooltip-01">
<button
class="db-button"
aria-describedby="tooltip-01"
data-has-tooltip="true"
>
Tooltip
<i class="db-tooltip" id="tooltip-01">Test</i>
</button>
<button class="db-button" aria-describedby="tooltip-02">
<button
class="db-button"
aria-describedby="tooltip-02"
data-has-tooltip="true"
>
Tooltip top
<i class="db-tooltip" data-placement="top" id="tooltip-02">Test</i>
</button>
<button class="db-button" aria-describedby="tooltip-03">
<button
class="db-button"
aria-describedby="tooltip-03"
data-has-tooltip="true"
>
Tooltip left
<i class="db-tooltip" data-placement="left" id="tooltip-03">Test</i>
</button>
<button class="db-button" aria-describedby="tooltip-04">
<button
class="db-button"
aria-describedby="tooltip-04"
data-has-tooltip="true"
>
Tooltip right
<i class="db-tooltip" data-placement="right" id="tooltip-04"
>Test</i
>
</button>
<button class="db-button" aria-describedby="tooltip-05">
<button
class="db-button"
aria-describedby="tooltip-05"
data-has-tooltip="true"
>
Tooltip Strong
<i class="db-tooltip" data-emphasis="strong" id="tooltip-05"
>Test</i
Expand Down
74 changes: 74 additions & 0 deletions packages/components/src/styles/internal/_popover-component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
@use "@db-ux/core-foundations/build/styles/screen-sizes";
@use "component";

$popover-gap-size: var(--db-popover-distance);
$popover-inset: calc(100% + #{$popover-gap-size} * var(--db-popover-gap, 0));
$popover-gap-inset: calc(-1 * #{$popover-gap-size});

%popover-center {
&:not([data-placement], [data-corrected-placement]),
&[data-placement="bottom"]:not([data-corrected-placement]),
Expand Down Expand Up @@ -79,6 +83,76 @@
&:is(.db-tooltip) {
--db-popover-distance: #{variables.$db-spacing-fixed-sm};
}

/* This is for pure html css without using JS */
&:not([data-corrected-placement]) {
&[data-placement^="bottom"],
&[data-placement^="top"] {
&[data-placement$="end"] {
inset-inline-end: 0;
}

&[data-placement$="start"] {
inset-inline-start: 0;
}
}

&[data-placement^="left"],
&[data-placement^="right"] {
&[data-placement$="end"] {
inset-block-end: 0;
}

&[data-placement$="start"] {
inset-block-start: 0;
}
}

&:not([data-placement]),
&[data-placement^="bottom"] {
inset-block-start: $popover-inset;

&::before {
inset-inline-start: 0;
inline-size: 100%;
block-size: $popover-gap-size;
inset-block-start: $popover-gap-inset;
}
}

&[data-placement^="top"] {
inset-block-end: $popover-inset;

&::before {
inset-inline-end: 0;
inline-size: 100%;
block-size: $popover-gap-size;
inset-block-end: $popover-gap-inset;
}
}

&[data-placement^="left"] {
inset-inline-end: $popover-inset;

&::before {
inset-block-end: 0;
block-size: 100%;
inline-size: $popover-gap-size;
inset-inline-end: $popover-gap-inset;
}
}

&[data-placement^="right"] {
inset-inline-start: $popover-inset;

&::before {
inset-block-start: 0;
block-size: 100%;
inline-size: $popover-gap-size;
inset-inline-start: $popover-gap-inset;
}
}
}
}

@mixin get-popover-show() {
Expand Down
Loading