Skip to content

refactor: replace slow performing CSS selectors #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nmerget merged 15 commits into from
Jun 4, 2025
Merged

refactor: replace slow performing CSS selectors #2968

nmerget merged 15 commits into from
Jun 4, 2025

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 3, 2024 •
edited
Loading

Proposed changes

Resolves #2967

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Aug 3, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 RC milestone Aug 3, 2024
@mfranzke mfranzke self-assigned this Aug 3, 2024
@mfranzke mfranzke linked an issue Aug 3, 2024 that may be closed by this pull request
slow performance CSS selectors #2967
Open
@mfranzke mfranzke changed the title refactor: replaced by simpler solution refactor: replace slow performance CSS selectors Aug 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2967-slow-performance-css-selectors

@github-actions github-actions bot added the 🧱components Changes inside components folder label Aug 3, 2024
bruno-sch
bruno-sch reviewed Aug 21, 2024
View reviewed changes
bruno-sch
bruno-sch previously approved these changes Aug 26, 2024
View reviewed changes
@mfranzke mfranzke changed the title refactor: replace slow performance CSS selectors refactor: replace slow performing CSS selectors Sep 22, 2024
@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
@nmerget nmerget marked this pull request as ready for review December 18, 2024 07:41
@nmerget nmerget enabled auto-merge (squash) December 18, 2024 07:41
@nmerget nmerget requested a review from bruno-sch January 28, 2025 07:19
@nmerget nmerget self-requested a review January 28, 2025 07:20
@mfranzke mfranzke requested review from Copilot and removed request for bruno-sch March 28, 2025 14:36
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/components/src/components/navigation/navigation.scss: Language not supported

@nmerget nmerget merged commit b3af151 into main Jun 4, 2025
74 checks passed
@nmerget nmerget deleted the 2967-slow-performance-css-selectors branch June 4, 2025 09:37
@github-project-automation github-project-automation bot moved this from 🏗 In development to ✅ Done in UX Engineering Team Backlog Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch

+1 more reviewer

@bruno-sch bruno-sch bruno-sch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mfranzke mfranzke

Labels

🧱components Changes inside components folder 🍄🆙improvement New feature or request

Projects

UX Engineering Team Backlog
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

slow performance CSS selectors

4 participants

@mfranzke @nmerget @bruno-sch