Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 6, 2023

Proposed changes

We should further differentiate the scripts we're providing:

  • Test screenshots should be possible to get generated more specifically, either easily and simply or by doing a rebuild after facing problems.
  • clean should do a git clean again, as the current simplified one does lead to problems on a quite frequent basis.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added this to the Guidelines 3.0 Alpha milestone Sep 6, 2023
@mfranzke mfranzke self-assigned this Sep 6, 2023
@mfranzke mfranzke enabled auto-merge September 6, 2023 20:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-scripts

@mfranzke mfranzke mentioned this pull request Sep 7, 2023
@mfranzke mfranzke requested a review from annsch September 7, 2023 10:16
@mfranzke
Copy link
Collaborator Author

mfranzke commented Sep 7, 2023

@annsch, as it looks good to you, would you please also leave your approval here?

@mfranzke mfranzke merged commit 9446a3b into main Sep 8, 2023
@mfranzke mfranzke deleted the refactor-scripts branch September 8, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants