Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 6, 2023

Proposed changes

Resolves https://github.com/db-ui/mono/issues/1365

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🧱components Changes inside components folder label Sep 6, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Sep 6, 2023
@mfranzke mfranzke requested a review from nmerget as a code owner September 6, 2023 20:39
@mfranzke mfranzke self-assigned this Sep 6, 2023
@mfranzke mfranzke linked an issue Sep 6, 2023 that may be closed by this pull request
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1365-select

@mfranzke mfranzke enabled auto-merge September 6, 2023 20:43
@annsch
Copy link
Contributor

annsch commented Sep 8, 2023

@mfranzke it looks like the asterisk has a bit too much space:

Bildschirmfoto 2023-09-08 um 09 43 27

@mfranzke mfranzke changed the title feat: select feat: select and displaying mandatory fields Sep 8, 2023
@mfranzke
Copy link
Collaborator Author

mfranzke commented Sep 8, 2023

@mfranzke it looks like the asterisk has a bit too much space:

Bildschirmfoto 2023-09-08 um 09 43 27

I'll cover this within https://github.com/db-ui/mono/pull/1545, as we should generalize it through all the different form elements.

@mfranzke mfranzke changed the title feat: select and displaying mandatory fields feat: select Sep 8, 2023
@mfranzke mfranzke disabled auto-merge September 8, 2023 13:56
@mfranzke mfranzke requested review from annsch and removed request for annsch September 8, 2023 13:56
@mfranzke mfranzke enabled auto-merge September 8, 2023 13:57
@mfranzke mfranzke disabled auto-merge September 8, 2023 13:57
@mfranzke mfranzke merged commit 4d9ea1e into main Sep 8, 2023
@mfranzke mfranzke deleted the 1365-select branch September 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧱components Changes inside components folder 📺showcases Changes to 1-n showcases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select - Concept

3 participants