Skip to content

fix: tag colors for emphasis strong #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmerget merged 5 commits into from
Aug 22, 2023
Merged

fix: tag colors for emphasis strong #1454

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4504769
fix: colors for tag to work with dark-mode
nmerget Aug 22, 2023
dd5b228
fix: tag colors for strong emphasis
nmerget Aug 22, 2023
c6460f5
Merge branch 'main' into fix-tag-colors
nmerget Aug 22, 2023
0ddcbc3
fix: tag colors for strong emphasis
nmerget Aug 22, 2023
83de12d
Merge remote-tracking branch 'origin/fix-tag-colors' into fix-tag-colors
nmerget Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/components/src/styles/tag-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@
@use "@db-ui/foundations/build/scss/color/color-variants" as *;
@use "@db-ui/foundations/build/scss/helpers/component" as *;

@mixin overwrite-strong-white() {
/* We force white as color for strong tags */
--db-current-color: #fff;
color: var(--db-current-color);
}

@mixin get-tag-colors() {
@extend %db-bg-neutral-strong;

&[data-emphasis="strong"] {
@extend %db-neutral-component;
@include overwrite-strong-white();
}

@each $name, $colors in $component-variants {
Expand All @@ -16,24 +23,32 @@

&[data-emphasis="strong"] {
@extend %db-critical-component;

@include overwrite-strong-white();
}
} @else if ($name == "informational") {
@extend %db-bg-informational;

&[data-emphasis="strong"] {
@extend %db-informational-component;

@include overwrite-strong-white();
}
} @else if ($name == "warning") {
@extend %db-bg-warning;

&[data-emphasis="strong"] {
@extend %db-warning-component;

@include overwrite-strong-white();
}
} @else if ($name == "successful") {
@extend %db-bg-successful;

&[data-emphasis="strong"] {
@extend %db-successful-component;

@include overwrite-strong-white();
}
}

Expand All @@ -45,6 +60,10 @@
}

@mixin get-tag-colors-interactive() {
&[data-emphasis="strong"] {
@include overwrite-strong-white();
}

&:has(input:not(:checked)) {
@extend %db-bg-neutral;
}
Expand All @@ -54,6 +73,7 @@

&[data-emphasis="strong"] {
@extend %db-neutral-component-ia;
@include overwrite-strong-white();
}

@each $name, $colors in $component-variants {
Expand All @@ -63,24 +83,32 @@

&[data-emphasis="strong"] {
@extend %db-critical-component-ia;

@include overwrite-strong-white();
}
} @else if ($name == "informational") {
@extend %db-bg-informational-ia;

&[data-emphasis="strong"] {
@extend %db-informational-component-ia;

@include overwrite-strong-white();
}
} @else if ($name == "warning") {
@extend %db-bg-warning-ia;

&[data-emphasis="strong"] {
@extend %db-warning-component-ia;

@include overwrite-strong-white();
}
} @else if ($name == "successful") {
@extend %db-bg-successful-ia;

&[data-emphasis="strong"] {
@extend %db-successful-component-ia;

@include overwrite-strong-white();
}
}

Expand Down