Skip to content

fix: incorrectly not inheriting values within details elements #1204 #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfranzke merged 8 commits into from
Jul 4, 2023
Merged

fix: incorrectly not inheriting values within details elements #1204 #1205

mfranzke merged 8 commits into from
Jul 4, 2023

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Jul 2, 2023 •
edited
Loading

Resolves https://github.com/db-ui/mono/issues/1204

Introducing a CSS variable to still be able to overwrite the box-sizing value (which is the spirit of this whole thing), instead of e.g. "redeclaring" the following:

details {
	& > *,
	& > ::before,
	& > ::after {
		box-sizing: border-box;
	}
}

but doing the following instead:
https://github.com/db-ui/mono/pull/1205/files#diff-3e45cc333da0df78a6653a7bd973570c0c815dd068b8b6c1a7394dee0655a479R126-R134

more information on the problem:
https://kittygiraudel.com/2021/08/23/shadow-roots-and-inheritance/ & https://stackoverflow.com/questions/75347448/box-sizing-not-inherited-through-details-element

See also db-ui/core#495

@mfranzke mfranzke added the 🐛bug Something isn't working label Jul 2, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Jul 2, 2023
@mfranzke mfranzke requested a review from nmerget as a code owner July 2, 2023 15:21
@mfranzke mfranzke self-assigned this Jul 2, 2023
@mfranzke mfranzke requested review from annsch and dkolba as code owners July 2, 2023 15:21
@mfranzke mfranzke linked an issue Jul 2, 2023 that may be closed by this pull request
Buttons in accordion inherit wrong box-sizing #1204
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1204-buttons-in-accordion-inherit-wrong-box-sizing

@mfranzke mfranzke enabled auto-merge July 3, 2023 08:10
@mfranzke mfranzke mentioned this pull request Jul 4, 2023
Merged
@mfranzke mfranzke merged commit 25569d4 into main Jul 4, 2023
@mfranzke mfranzke deleted the 1204-buttons-in-accordion-inherit-wrong-box-sizing branch July 4, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

@mfranzke mfranzke

Labels

🐛bug Something isn't working

Projects

None yet

Milestone

Open Beta Release (0.1.0)

Development

Successfully merging this pull request may close these issues.

Buttons in accordion inherit wrong box-sizing

3 participants

@mfranzke @nmerget