feat: add navigation-item component #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-nav-item-component |
github-actions
bot
added
🧱components
mfranzke
reviewed
Jun 20, 2023
This reverts commit 972f22b.
…nent # Conflicts: # __snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/home/showcase-home.spec.ts-snapshots/Home-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/home/showcase-home.spec.ts-snapshots/Home-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png
…at-nav-item-component
…nent # Conflicts: # __snapshots__/button/showcase-button.spec.ts-snapshots/DBButton-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/home/showcase-home.spec.ts-snapshots/Home-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/infotext/showcase-infotext.spec.ts-snapshots/DBInfotext-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/input/showcase-input.spec.ts-snapshots/DBInput-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-webkit-linux.png # __snapshots__/link/showcase-link.spec.ts-snapshots/DBLink-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png # __snapshots__/section/showcase-section.spec.ts-snapshots/DBSection-should-match-screenshot-for-tonality-regular-and-color-neutral-0-1-chromium-linux.png
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.lite.tsx
Outdated
Show resolved
Hide resolved
mfranzke
reviewed
Jul 2, 2023
mfranzke
reviewed
Jul 2, 2023
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.lite.tsx
Show resolved
Hide resolved
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.lite.tsx
Show resolved
Hide resolved
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.lite.tsx
Outdated
Show resolved
Hide resolved
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.lite.tsx
Outdated
Show resolved
Hide resolved
mfranzke
reviewed
Jul 2, 2023
packages/components/src/components/navigation-item/navigation-item.scss
Outdated
Show resolved
Hide resolved
…nent # Conflicts: # __snapshots__/button/showcase/chromium/regular/neutral-0/DBButton-should-match-screenshot.png # __snapshots__/button/showcase/mobile-chrome/regular/neutral-0/DBButton-should-match-screenshot.png # __snapshots__/button/showcase/mobile-safari/regular/neutral-0/DBButton-should-match-screenshot.png # __snapshots__/button/showcase/webkit/regular/neutral-0/DBButton-should-match-screenshot.png # __snapshots__/infotext/showcase/chromium/regular/neutral-0/DBInfotext-should-match-screenshot.png # __snapshots__/infotext/showcase/mobile-chrome/regular/neutral-0/DBInfotext-should-match-screenshot.png # __snapshots__/infotext/showcase/mobile-safari/regular/neutral-0/DBInfotext-should-match-screenshot.png # __snapshots__/infotext/showcase/webkit/regular/neutral-0/DBInfotext-should-match-screenshot.png # __snapshots__/input/showcase/chromium/regular/neutral-0/DBInput-should-match-screenshot.png # __snapshots__/input/showcase/mobile-chrome/regular/neutral-0/DBInput-should-match-screenshot.png # __snapshots__/input/showcase/mobile-safari/regular/neutral-0/DBInput-should-match-screenshot.png # __snapshots__/input/showcase/webkit/regular/neutral-0/DBInput-should-match-screenshot.png # __snapshots__/link/showcase/chromium/regular/neutral-0/DBLink-should-match-screenshot.png # __snapshots__/link/showcase/mobile-chrome/regular/neutral-0/DBLink-should-match-screenshot.png # __snapshots__/link/showcase/mobile-safari/regular/neutral-0/DBLink-should-match-screenshot.png # __snapshots__/link/showcase/webkit/regular/neutral-0/DBLink-should-match-screenshot.png # __snapshots__/section/showcase/chromium/regular/neutral-0/DBSection-should-match-screenshot.png # __snapshots__/section/showcase/mobile-chrome/regular/neutral-0/DBSection-should-match-screenshot.png # __snapshots__/section/showcase/mobile-safari/regular/neutral-0/DBSection-should-match-screenshot.png # __snapshots__/section/showcase/webkit/regular/neutral-0/DBSection-should-match-screenshot.png
annsch
approved these changes
Jul 6, 2023
mfranzke
reviewed
Jul 10, 2023
| ... | ||
| <body> | ||
| <a href="mypath"> | ||
| <li aria-haspopup="false" class="db-navigation-item"> |
Collaborator
There was a problem hiding this comment.
aria-haspopup isn't supposed to get set on tags with this role:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-haspopup#associated_roles
mfranzke
reviewed
Jul 10, 2023
Comment on lines
+15
to
+16
| <!-- If you want to use it as main-naivgation with pulse--> | ||
| <div class="active-indicator" /> |
Collaborator
There was a problem hiding this comment.
We should check whether we really need a block level element for this and cannot achieve it either via ::after { content: ""; } or at least changing it to a <span>.
mfranzke
reviewed
Jul 10, 2023
| state.iconVisible(props.iconAfter) ? props.iconAfter : undefined | ||
| } | ||
| aria-current={props.active ? 'page' : undefined} | ||
| data-disabled={props.disabled} |
Collaborator
There was a problem hiding this comment.
We should use aria-disabled instead of data-disabled, as the latter doesn't imply any semantic meaning which we'd like to enable by using aria-disabled instead.
mfranzke
reviewed
Jul 10, 2023
| return ( | ||
| <li | ||
| ref={component} | ||
| role={state.hasAreaPopup ? 'button' : ''} |
Collaborator
There was a problem hiding this comment.
This would lead to having several buttons and menus wrapped into each other, which would either be a nightmare or totally abstracted content especially to screenreader users.
mfranzke
reviewed
Jul 10, 2023
| if (children?.length > 0) { | ||
| state.hasAreaPopup = true; | ||
| } else { | ||
| state.hideSubNavigation = true; |
Collaborator
There was a problem hiding this comment.
This it not necessarily about showing or hiding depending on a (dynamic like e.g. viewport size) condition, but not having any subitems and that for we wouldn't want to render that part. So it might be more clear and even also separated from the visual meaning to name it e.g. like lacksSubNavigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.