Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with checkbox icon #3264

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: issue with checkbox icon #3264

wants to merge 6 commits into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Sep 30, 2024

Proposed changes

closes #3240

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) September 30, 2024 14:08
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-checkbox-issue

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Sep 30, 2024
mfranzke
mfranzke reviewed Sep 30, 2024
View reviewed changes
...se/mobile-safari/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png
Copy link
Member

@mfranzke mfranzke Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dash included within the indetermine (but not the valid one) checkbox is now misplaced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mfranzke mfranzke mentioned this pull request Sep 30, 2024
Merged
5 tasks
@nmerget nmerget requested a review from mfranzke October 1, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox icon misaligned if label text wraps
2 participants
@nmerget @mfranzke