feat: file watcher #2306
Draft
feat: file watcher #2306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunogrbavac
force-pushed
the
feat-file-watcher
branch
from
35a858e to
6281f12
Compare
… inotifywait Signed-off-by: Bruno Grbavac <[email protected]>
Signed-off-by: Bruno Grbavac <[email protected]>
Signed-off-by: Bruno Grbavac <[email protected]>
Signed-off-by: Bruno Grbavac <[email protected]>
…ith dns resolution Signed-off-by: Bruno Grbavac <[email protected]>
Signed-off-by: Bruno Grbavac <[email protected]>
brunogrbavac
force-pushed
the
feat-file-watcher
branch
from
6281f12 to
9257340
Compare
Signed-off-by: Bruno Grbavac <[email protected]>
…method Signed-off-by: MDzaja <[email protected]>
MDzaja
requested changes
Aug 27, 2025
Comment on lines
+54
to
+83
| class WatchHandle: | ||
| """Handle for a file watching session.""" | ||
|
|
||
| def __init__(self, close_func: Callable[[], None]): | ||
| """Initialize a new WatchHandle. | ||
|
|
||
| Args: | ||
| close_func: Function to call to stop watching | ||
| """ | ||
| self._close_func = close_func | ||
|
|
||
| async def close(self) -> None: | ||
| """Stop watching the directory.""" | ||
| self._close_func() | ||
|
|
||
|
|
||
| class SyncWatchHandle: | ||
| """Synchronous handle for a file watching session.""" | ||
|
|
||
| def __init__(self, close_func: Callable[[], None]): | ||
| """Initialize a new SyncWatchHandle. | ||
|
|
||
| Args: | ||
| close_func: Function to call to stop watching | ||
| """ | ||
| self._close_func = close_func | ||
|
|
||
| def close(self) -> None: | ||
| """Stop watching the directory.""" | ||
| self._close_func() |
There was a problem hiding this comment.
I’d move these into _sync/_async file_watcher.py, since they differ per module. I’d also rename the async version to AsyncWatchHandle and the sync version to WatchHandle (auto-generated from the async one) to stay consistent with the naming convention of other existing classes.
There was a problem hiding this comment.
You can add this to docs:file-watcher and docs:async-file-watcher in package.json so the documentation gets autogenerated under the File Watcher page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File Watching Support to Daytona SDKs
Description
Adds real-time file watching capabilities to both TypeScript and Python SDKs via WebSocket connections.
Features
Key Changes
FileSystemclass withwatchFiles()methodwatch_files()method with async context managerfsnotify