Skip to content

fix(runner): add retry to destroy, remove and stop sandbox #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(runner): add retry to destroy, remove and stop sandbox #2300

wants to merge 3 commits into from

Conversation

lbrecic
Copy link
Contributor

@lbrecic lbrecic commented Aug 21, 2025

Add retry to destroy, remove and stop container

Description

This PR adds retry mechanism to remove, destroy and stop sandbox operations

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

@lbrecic lbrecic force-pushed the stop-remove-retry branch from 3906a84 to 9cff995 Compare August 21, 2025 12:21
@lbrecic lbrecic marked this pull request as ready for review August 21, 2025 13:14
Tpuljak
Tpuljak requested changes Aug 21, 2025
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an exponential backoff helper or something. There's 3 diffs in the PR that share 90% of the same code

@lbrecic lbrecic requested a review from Tpuljak August 21, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpuljak Tpuljak Awaiting requested review from Tpuljak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbrecic @Tpuljak