Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade lit #66

Merged
merged 1 commit into from
Oct 29, 2023
Merged

chore: upgrade lit #66

merged 1 commit into from
Oct 29, 2023

Conversation

zsoerenm
Copy link
Contributor

Lit v3 has been released. It is vastly compatibly with Lit v2. Some small changes were necessary (e.g. decorators should be imported from lit/decorators.js instead of lit-element).

Unfortunately, when I try to npm run build I run into the following error:

./src/index.ts → ./dist/infinite-viewer.umd.js...
(!) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/lit-element/lit-element.js: (6:195)
[!] Error: Unexpected token
../../node_modules/lit-element/lit-element.js (6:195)
4:  * Copyright 2017 Google LLC
5:  * SPDX-License-Identifier: BSD-3-Clause
6:  */class s extends t{constructor(){super(...arguments),this.renderOptions={host:this},this._$Do=void 0}createRenderRoot(){const t=super.createRenderRoot();return this.renderOptions.renderBefore??=t.firstChild,t}update(t){const i=this.render(); // I shortened this
                                                                                                                                                                                                      ^
7: //# sourceMappingURL=lit-element.js.map
Error: Unexpected token
    at error (/home/schoenbrod/Code/infinite-viewer/node_modules/rollup/dist/shared/node-entry.js:5400:30)
    at Module.error (/home/schoenbrod/Code/infinite-viewer/node_modules/rollup/dist/shared/node-entry.js:9824:16)

It looks like ??= is an unexpected token. However, this token is valid since node v15.
I'm running node v20.8.1

node -v
v20.8.1

Do you have any thoughts on this?

Lit v3 has been released. It is vastly compatibly with Lit v2. Some
small changes were necessary (e.g. decorators should be imported from
lit/decorators.js instead of lit-element).
@daybrush
Copy link
Owner

@zsoerenm
It will be released soon with bug fixes.

@daybrush daybrush merged commit 96425ea into daybrush:master Oct 29, 2023
@daybrush
Copy link
Owner

@zsoerenm

  • infinite-viewer 0.29.1
  • lit-infinite-viewer 0.27.1
  • preact-infinite-viewer 0.25.1
  • react-infinite-viewer 0.28.1
  • svelte-infinite-viewer 0.27.1
  • vue-infinite-viewer 0.27.1
  • vue3-infinite-viewer 0.17.1
  • ngx-infinite-viewer 0.27.1

infinite-viewer's new version is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants