Skip to content

Fix variance safety check #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021
Merged

Fix variance safety check #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/vm/methodtablebuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3035,8 +3035,8 @@ MethodTableBuilder::EnumerateClassMethods()

// Check the appearance of covariant and contravariant in the method signature
// Note that variance is only supported for interfaces, and these rules are not
// checked for static methods as they cannot be called variantly.
if ((bmtGenerics->pVarianceInfo != NULL) && !IsMdStatic(dwMemberAttrs))
// checked for non-virtual static methods as they cannot be called variantly.
if ((bmtGenerics->pVarianceInfo != NULL) && (IsMdVirtual(dwMemberAttrs) || !IsMdStatic(dwMemberAttrs)))
{
SigPointer sp(pMemberSignature, cMemberSignature);
uint32_t callConv;
Expand Down