Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To .Net 5 #3

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

To .Net 5 #3

wants to merge 2 commits into from

Conversation

CommCody
Copy link

I'm trying to upgrade your playground to .net 5, I'm hitting two issues:

  1. the css has changed and I've tried to fix it, but it's not exactly right
  2. The loading of the assemblies to get the MetadataReference needs changing because Location on the assemblies is now an empty string, I've worked around this by assuming that the Name of the assembly is the name of the dll on disk.
  3. I've had to change the csproj options to ensure the dlls get put on disk individually

I still have to do some cleanup, but if you could already take a look?

@davidwengier
Copy link
Owner

davidwengier commented Mar 17, 2021

Thanks for the PR, sorry I didn't look at this. I did a trial upgrade of another project (copied from this one originally) to .NET 5 in davidwengier/DecompilationDiffer#1 and ran into an issue, namely dotnet/runtime#43411, which blocks upgrading because Roslyn uses Parallel.For internally. Not sure whether the other changes in here somehow work around that (though I can't see how they would) but I think .NET 5 is not going to work for this project sadly. Will have to wait for .NET 6 if/when that issue gets fixed. Nevermind can work around it :)

Base automatically changed from master to main March 17, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants