-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update focus-trap -> focus-trap-react in dependencies #89
Comments
This PR seems to solve the issue https://github.com/davidtheclark/react-aria-modal/pull/110/files . @davidtheclark @wldcordeiro It will be great to merge this one ! For others who, like me, has the "Uncaught Error: initialFocus refers to no known node" error, I installed the dependency from @marcolanaro 's fork as a workaround: |
I finally ended up using https://www.npmjs.com/package/@justfixnyc/react-aria-modal |
Not sure, but it looks like the issue has been already resolved 🤔 https://github.com/focus-trap/focus-trap-react/blob/master/package.json#L94 https://github.com/davidtheclark/react-aria-modal/blob/master/package.json#L34 |
Hi! After fixing this issue in focus-trap focus-trap/focus-trap#81, could you please update focus-trap`s version in focus-trap-react https://github.com/davidtheclark/focus-trap-react/blob/master/package.json and in react-aria-modal so we can use the new functionality in our project? Thanks
The text was updated successfully, but these errors were encountered: