Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focus-trap -> focus-trap-react in dependencies #89

Open
SonyaOrlova opened this issue Jun 4, 2019 · 3 comments
Open

Update focus-trap -> focus-trap-react in dependencies #89

SonyaOrlova opened this issue Jun 4, 2019 · 3 comments

Comments

@SonyaOrlova
Copy link

Hi! After fixing this issue in focus-trap focus-trap/focus-trap#81, could you please update focus-trap`s version in focus-trap-react https://github.com/davidtheclark/focus-trap-react/blob/master/package.json and in react-aria-modal so we can use the new functionality in our project? Thanks

@rdubigny
Copy link

rdubigny commented Aug 20, 2020

This PR seems to solve the issue https://github.com/davidtheclark/react-aria-modal/pull/110/files .

@davidtheclark @wldcordeiro It will be great to merge this one !

For others who, like me, has the "Uncaught Error: initialFocus refers to no known node" error, I installed the dependency from @marcolanaro 's fork as a workaround: npm install https://github.com/rdubigny/react-aria-modal

@rdubigny
Copy link

I finally ended up using https://www.npmjs.com/package/@justfixnyc/react-aria-modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants