Fix to handle orientation Exif data in vertical images, improving alignment #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation of mtcnn will be deprecated with the new version of scipy. In addition, (and most motivating for me), the scipy.misc imread function ignores the image's Orientation Exif flag, meaning vertical images can be read in rotated, greating decreasing performance. This branch converts all scipy.misc functions in align_dataset_mtcnn.py to the appropriate and suggested equivalents in the imageio package. This introduces a new project dependency on imageio, but the orientation data is now considered and handled appropriately.
|
I'll note these changes should probably also be made everywhere else scipy.misc is used to keep behavior consistent. |
|
@gavinwtaylor please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current use of scipy.misc for image reading/writing/resizing in the
implementation of mtcnn will be deprecated with the new version of scipy. In
addition, (and most motivating for me), the scipy.misc imread function ignores
the image's Orientation Exif flag, meaning vertical images can be read in
rotated, greatly decreasing alignment performance.
This branch converts all scipy.misc functions in align_dataset_mtcnn.py to the
appropriate and suggested equivalents in the imageio package. This introduces
a new project dependency on imageio, but the orientation data is now
considered and handled appropriately.