Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a few fmt::formatter types #118

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sadguitarius
Copy link
Contributor

Hi @davidmoreno, I was having trouble building with the most recent commit and it looks like others may have run into similar issues. Does this commit break anything for you? It seems like it's working fine for me so far. Thanks!

@sadguitarius
Copy link
Contributor Author

Ok it's failing the CI test but it's working fine for me locally. I don't think anything I added would be causing that error but who knows? Can you take a look when you get a chance? Thanks!

@sadguitarius
Copy link
Contributor Author

sadguitarius commented Sep 5, 2024

whoops I missed the other PR here, that probably fixes the same thing...

@davidmoreno davidmoreno merged commit d47ed35 into davidmoreno:master Sep 5, 2024
1 check failed
@davidmoreno
Copy link
Owner

Thanks!

I finally reimplemented them using format_as, that I didn't know before and makes formatting enums quite easy ( copilot gave me the final trick, using a macro, that makes it really easy). But thanks for the pointer.

For me it complied without any problems. What distro are you using?

I'm on Ubuntu 24.04.

@sadguitarius
Copy link
Contributor Author

Oh cool, glad it all worked out! I really don't understand the fmt templates at all, just going through the compiler errors until it stops yelling at me, so I'm sure my solutions are less than ideal. I'm on Arch, which is currently on fmt 10.2.0.

@sadguitarius
Copy link
Contributor Author

Oh I just checked out the format_as implementation, so much easier on the eyes!

@sadguitarius sadguitarius deleted the add-formatters branch September 6, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants