New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consider chunkOverlap in TextSplitter #640

Open

FaFre wants to merge 1 commit into davidmigloz:main from FaFre:fix_chunk_overlap

+11 −25

FaFre commented Jan 16, 2025

Until now the chunkOverlap parameter did not have any effect :)

Ported the logic from following source file: https://api.python.langchain.com/en/latest/_modules/langchain_text_splitters/base.html#TextSplitter


          consider chunkOverlap

31424b0

Owner

davidmigloz commented Jan 27, 2025

ohh good catch! 😅
would you mind including a test?

davidmigloz added c:doc-transformers p:langchain t:bug labels

davidmigloz assigned FaFre

davidmigloz added this to the Next release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c:doc-transformers p:langchain t:bug