Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few callbacks #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added a few callbacks #38

wants to merge 4 commits into from

Conversation

smiLLe
Copy link

@smiLLe smiLLe commented Jan 22, 2019

I was missing a few callbacks i found useful in flutter_redux. So here are:

  • onInit
  • onFirstBuild
  • onDidChange
  • onDispose

Implemented for StoreConnector and StoreConnection.
I also added tests, however i am no expert in flutter tests :)

@codecov-io
Copy link

Codecov Report

Merging #38 into master will increase coverage by 5.35%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   85.71%   91.07%   +5.35%     
==========================================
  Files           1        1              
  Lines          35       56      +21     
==========================================
+ Hits           30       51      +21     
  Misses          5        5
Impacted Files Coverage Δ
lib/flutter_built_redux.dart 91.07% <92.85%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6903b31...551b69e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants