Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid scroll into view extra dep in chipped component #900

Conversation

davidlj95
Copy link
Owner

It was mainly introduced for testing purposes. However, spies can be used instead of adding a dependency for that (which comes with a bundle size overhead).

Tests the scroll using spies and later removes that scroll into view dependency. Has been a good test case for #899. After scroll into view wasn't used by the component, it was reported as unused. Yay!

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (c464579) to head (71544d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   98.31%   98.30%   -0.02%     
==========================================
  Files         122      121       -1     
  Lines         595      589       -6     
  Branches       62       60       -2     
==========================================
- Hits          585      579       -6     
  Misses          6        6              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 840256e into main Nov 29, 2024
16 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-avoid-scroll-into-view-extra-dep-in-chipped-component branch November 29, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant