Change the way we test and verify allocation consistency #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is that `are_flags_valid` is hard to get right and hard to keep up-to-date. The plan is to delete it and the test that depends on it - `test_resolution_allocation_consistency`. However, when inconsistent allocations occur, it can be hard to figure out what combination of flags caused the inconsistent allocation. So we reuse the consistency checking mecanism used by the test from the linker proper, but only when an environment variable is set. When we detect an inconsistency at write-time, we now suggest setting this environment variable to get more info.
See previous commit for motivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.