Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically open an issue on a new upstream release #280

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AA-Turner
Copy link
Contributor

Suggested in response to #273 (comment). Another alternative would be to automatically make a release, but I don't know if you'd want that.

A

@@ -44,4 +44,5 @@
print(
f"Local version {local_version} does not match upstream version {upstream_version}"
)
os.environ["LIBPHONENUMBER_UPSTREAM_VERSION"] = upstream_version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work – IIRC environment variables are only visible to child processes, not parents.

with:
# language=JavaScript
script: |
await github.rest.issues.create({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this create a new issue on every failed run of the workflow?

I'm thinking that if I'm away for a week and a release happens to come out at the start, would I return to 14 identical issues? :-)

@daviddrysdale
Copy link
Owner

Thanks, this seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants