-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set function name to newFn #17
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! This looks good to me. @kronicker Can you think of any possible unintended consequences of this before we merge? I think this is only a minor version bump, but can anyone think of a way it might break existing behaviour requiring a major? |
@davidbanham I don't think so. Express does not rely on function names anywhere, only on arity. Thinking about it, I think I wanted to do this originally. |
Awesome! Thanks for taking a look. I'll release tomorrow. |
Let's be nitpicky cause this thing can easily confuse people and is pretty nonstandard Regarding major/minor issue, FWIW I'm also in minor camp 👍 |
@vladimyr How about making it |
Seems like we're all happy to move ahead on the @vladimyr does that work for you? If there's no howls of dissent in the next week or so I'll update this PR with the |
@davidbanham are you going to change |
Simply sets the function name to the new function during wrap.
Ref #16