Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinearAlgebra for Julia 0.7 #68

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Update LinearAlgebra for Julia 0.7 #68

merged 2 commits into from
Aug 24, 2018

Conversation

diegozea
Copy link
Contributor

@diegozea diegozea commented Aug 23, 2018

This solves one of the TODO annotated tests in arithmetic.

Hint on the others: I saw that others TODO tests are failing because of transpose and permutedims, that were changed in Julia 0.7.

Cheers,

@diegozea diegozea changed the title Solve *(NamedMatrix, NamedMatrix) name problems in Julia 0.7 Update LinearAlgebra for Julia 0.7 Aug 23, 2018
@diegozea
Copy link
Contributor Author

Now there are very few things to solve :)

@davidavdav davidavdav merged commit 613a955 into davidavdav:master Aug 24, 2018
@davidavdav
Copy link
Owner

FYI I am trying to see if we can move LinearAlgebra stuff to parts in the code that are loaded only when LinearAlgebra is used, see #67, and similarly for other library stuff that has been moved out of julia Base.

But the latest Require works differently than before, and the discussion there is too convolved for me to follow.

@diegozea
Copy link
Contributor Author

diegozea commented Aug 24, 2018

I think that it's ok to depend on modules from the standard libraries, e.g. LinearAlgebra and Random, because they are shipped with Julia. But, I agree with you that Requires.jl will be useful for things that are now on external libraries. I haven't used Requires on Julia 0.7 yet, but I can try for the external libraries. What do you think it's still needed to tag a NamedArrays version for 0.7?

@davidavdav
Copy link
Owner

There still are a number of TODOs in the test,

  • convert
  • sort
  • broadcast
    I would be less worried about the linear algebra stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants