-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static asset compilation errors are ignored #35
Comments
I accidentally created this task without a body. Just updated it with content. |
I just did some tests and it actually appears that the @davidalger In order to fully support 2.0.x, we'll need to do two checks: For 2.0.x, revert to checking for "Compilation from source" I wonder how much longer |
For as long as 2.0 is a supported major release ;)
This is actually supposed to be automatic. If the exit code of a command is non-zero, the deploy fails…I just verified this is the case with
I believe the reason I switched away from this in the first place is because that is only one potential error it could spit out. Whats to say there couldn't be other error related strings in the output? Hence the switch to a positive check, which I assumed? worked when I implemented it having no broken code to test with :) based on the output above, this assumed to be positive message shows regardless of there being errors or not. I'm considering implementing a check for the number of errors reported. It would iterate over each line and check the |
@erikhansen See above pushed commit for the type of implementation I'm suggesting. Open to any feedback. Want to make sure I get it right this time! ;) |
…e 'within' parts of tasks Issue #35
…e 'within' parts of tasks Issue #35
@erikhansen I've made some additional changes and submitted a PR to develop. Please review. The positive check for presence of the "New version…" text is necessary, as it won't be there (and neither will the "errors: xyz" text) in the case of an Exception being thrown. This can be easily seen if you (for example) run the console command with an invalid option triggering a RuntimeException. |
@davidalger I look forward to reviewing your PR. I won't be able to review it until early next week, but when I do, I can test it locally to ensure it works with the specific use that prompted me to create this issue. |
@davidalger I checked out your FYI, I did not test this on a 2.0.x install. |
The changes have been pushed up as part of v0.5.4. |
I'm using Magento EE 2.1.1 with Capistrano 0.5.1. Capistrano is ignoring static asset compilation errors. Screenshot demonstrating problem (I changed
command_output
totrue
to see all output for the sake of debugging):In this commit, the explicit check for the "Compilation from source" error message was removed. In order to fix this issue, I propose that this check gets added back (and possibly ALSO check for the presence of the "New version of deployed files" success message).
If you'd like me to submit this as a PR, let me know.
The text was updated successfully, but these errors were encountered: