Set -release instead of -target since Scala 2.13.9, close #646 #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Motivation: Scala 2.13.9 has deprecated -release in favor of -target, see https://www.scala-lang.org/news/2.13.9 As our default value for `release` is plugged onto `maven.compiler.target`, we end up with the default behavior of setting `-release:8` which now triggers a warning. Modification: Don't set `-release` is it's deprecated. If `target` is not explicitly defined, use the `release` value to set the `target` instead. Result: No more deprecation warning
slandelle
force-pushed
the
646-target-deprecation
branch
from
86fc135 to
6271f80
Compare
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Nov 6, 2022
### What changes were proposed in this pull request? This pr aims upgrade scala-maven-plugin to 4.7.2 ### Why are the changes needed? This version set `-release` instead of `-target` to clean up a deprecation compilation warning for Scala 2.13.9 - davidB/scala-maven-plugin#648 The all change from 4.7.1 as follows: - davidB/scala-maven-plugin@4.7.1...4.7.2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes #38524 from LuciferYang/SPARK-41024. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This pr aims upgrade scala-maven-plugin to 4.7.2 ### Why are the changes needed? This version set `-release` instead of `-target` to clean up a deprecation compilation warning for Scala 2.13.9 - davidB/scala-maven-plugin#648 The all change from 4.7.1 as follows: - davidB/scala-maven-plugin@4.7.1...4.7.2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#38524 from LuciferYang/SPARK-41024. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Scala 2.13.9 has deprecated -release in favor of -target, see https://www.scala-lang.org/news/2.13.9
As our default value for
releaseis plugged ontomaven.compiler.target, we end up with the default behavior of setting-release:8which now triggers a warning.Modification:
Don't set
-releaseis it's deprecated. Iftargetis not explicitly defined, use thereleasevalue to set thetargetinstead.Result:
No more deprecation warning