Add error handling in init #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2015 10:46
Error handling allows a dependent to check for errors nicely. You don't have to check for undefined anymore. Just use the err variable transmitted with the init-callback. The error either transmits the err from the read call or builds an own error. The own error simply states that no packages weren't found. If everything is fine, err will be null, For downward compatibility to other dependents, the err is submitted after the sorted (or filtered)
|
Added with commit 1a93a41 I don't close this yet |
added 2 commits
September 8, 2015 11:21
Conflicts: tests/test.js
|
Update this PR as you updated your test policy. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling allows a dependent to check for errors nicely.
You don't have to check for undefined anymore.
Just use the err variable transmitted with the init-callback.
The error either transmits the err from the read call or builds an own error.
The own error simply states that no packages weren't found.
If everything is fine, err will be null,
For downward compatibility to other dependents, the err is submitted after the sorted (or filtered)