Fix the "--failOn MIT;ISC" end to end test #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So sorry I missed this. Thank you for catching it! |
davglass
approved these changes
Mar 20, 2018
|
Thanks! Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure why it is not failing on the Travis CI, but locally the test failed consistently for me. When I tried it manually, the behavior was correct, but I noticed the test doesn't do exactly what it says. I fixed the tests.
Then I had a thought it would be nice to give warning about the change from commas to semicolons, so I implemented a naive alert to users when they do use commas with the
--failOnand--onlyAllowarguments. I tested this change as well.