fix: add autocomplete attributes to sign-up form inputs #240
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0mer
force-pushed
the
fix/add-autocomplete-to-signup-form
branch
2 times, most recently
from
7bfc0d6 to
b648266
Compare
The sign-up form is missing autoComplete attributes on several input fields, which causes browser warnings about missing autocomplete attributes.
This PR adds:
- autoComplete="name" to the name input field
- autoComplete="username" to the username input field
- autoComplete="email" to the email input field
- autoComplete={field} to additional field inputs (number and text types)
Note: Password inputs already have autoComplete="new-password" set correctly.
The sign-in form already has proper autocomplete attributes, so this PR brings the sign-up form to the same standard.
This addresses browser accessibility warnings and improves form usability with password managers and autofill features.
n0mer
force-pushed
the
fix/add-autocomplete-to-signup-form
branch
from
b648266 to
52c1a5a
Compare
daveycodez
reviewed
Nov 14, 2025
| "number" ? ( | ||
| <Input | ||
|
|
||
| autoComplete={field} |
Contributor
There was a problem hiding this comment.
I don't think we can put dynamic fields into autoComplete here since they could be invalid options for this prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sign-up form is missing autoComplete attributes on several input fields, which causes browser warnings about missing autocomplete attributes.
This PR adds:
Note: Password inputs already have autoComplete="new-password" set correctly.
The sign-in form already has proper autocomplete attributes, so this PR brings the sign-up form to the same standard.
This addresses browser accessibility warnings and improves form usability with password managers and autofill features.