Skip to content

fix: add autocomplete attributes to sign-up form inputs #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix: add autocomplete attributes to sign-up form inputs #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/auth/forms/sign-up-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,7 @@ export function SignUpForm({

<FormControl>
<Input
autoComplete="name"
className={classNames?.input}
placeholder={
localization.NAME_PLACEHOLDER
Expand Down Expand Up @@ -539,6 +540,7 @@ export function SignUpForm({

<FormControl>
<Input
autoComplete="username"
className={classNames?.input}
placeholder={
localization.USERNAME_PLACEHOLDER
Expand Down Expand Up @@ -566,6 +568,7 @@ export function SignUpForm({

<FormControl>
<Input
autoComplete="email"
className={classNames?.input}
type="email"
placeholder={localization.EMAIL_PLACEHOLDER}
Expand Down Expand Up @@ -695,6 +698,8 @@ export function SignUpForm({
{additionalField.type ===
"number" ? (
<Input

autoComplete={field}
Copy link
Contributor

@daveycodez daveycodez Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can put dynamic fields into autoComplete here since they could be invalid options for this prop.

className={
classNames?.input
}
Expand Down Expand Up @@ -732,6 +737,8 @@ export function SignUpForm({
/>
) : (
<Input

autoComplete={field}
className={
classNames?.input
}
Expand Down