[release, 1.1.3] various improvements #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded dependencies
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.5.0 to 8.6.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.5.0...v8.6.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [husky](https://github.com/typicode/husky) from 8.0.2 to 8.0.3. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v8.0.2...v8.0.3) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 8.30.0 to 8.35.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.30.0...v8.35.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@snyk/protect](https://github.com/snyk/snyk) from 1.1073.0 to 1.1111.0. - [Release notes](https://github.com/snyk/snyk/releases) - [Commits](snyk/cli@v1.1073.0...v1.1111.0) --- updated-dependencies: - dependency-name: "@snyk/protect" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AXIOS-6144788
The code attempts to validate transaction types, which unnecessarily limits the module now. Defining the allowable transaction types isn't the right way to do this either - it will just cause issues going forward. If we remove validation, and the dev requests a txType that doesn't exist, the code fails just as before. Adding validation in this wrapper doesn't add anything (except it does hide the actual error with a vague "Validation error" message). Removing this line fixes two issues: 1. Incorrect "isRequired" validation - txTypes is not a mandatory parameter 2. Incorrect txTypes options subset - there are many more transaction types than Brokerage and Trade. See here: https://github.com/independentreserve/dotNetApiClient/blob/b314952ef35ca65758bd826e2b735d33ca227e1f/src/DotNetClientApi/Data/TransactionType.cs#L12
The max is now 5,000, according to: https://www.independentreserve.com/au/features/api#GetTransactions
[BUG, issue #770] remove validation on txTypes for getTransactions
…s-pageSize [BUG, issue #773] pageSize max increase to 5000 for getTransactions
…a308d2dde [Snyk] Security upgrade axios from 0.27.2 to 1.6.4
…tect-1.1111.0 Bump @snyk/protect from 1.1073.0 to 1.1111.0
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
….35.0 Bump eslint from 8.30.0 to 8.35.0
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.5 to 7.24.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…onfig-prettier-8.6.0 Bump eslint-config-prettier from 8.5.0 to 8.6.0
Bump husky from 8.0.2 to 8.0.3
Bump json5 from 1.0.1 to 1.0.2
…edirects-1.15.6 Bump follow-redirects from 1.15.4 to 1.15.6
…averse-7.24.6 Bump @babel/traverse from 7.20.5 to 7.24.6
Snyk has created this PR to upgrade axios from 1.6.4 to 1.6.8. See this package in npm: axios See this project in Snyk: https://app.snyk.io/org/davesag/project/29c6cffc-0abe-4762-a340-f02fc47e331d?utm_source=github&utm_medium=referral&page=upgrade-pr
…36c089a70a67d [Snyk] Upgrade axios from 1.6.4 to 1.6.8
…Transactions #775 add includeTotals param to getTransactions
davesag
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.