You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@davegill
I actually thought that was the case too. I do have it turned off in the restart test for the tests I conduct manually, but tested it this way and still got BFB results, so I wasn't sure. You know DFI better than I do, so if you think it should be off, then it definitely should be.
@kkeene44
Kelly,
In the comments section, would you add something that could be a template to follow for your future additions. Such as
1. Directory name: dfi
2. Perturbations from basic:
. Uses DFI option=3
. Requires 1 hour backward and 1 hour forward simulations
. Total time of 2 h 12 min instead of 12 min
You are good at this sort of detailed information. Likely, this will be for your benefit
@kkeene44
Kelly,
Riiight, likely the DFI is not "done" on the restart since we start after the initial time. But for clarity, set the dfi_opt=0 (or zap the whole dfi namelist record) on namelist.input.3.
@kkeene44
Kelly,
I updated the wrf-coop repo (which is what runs the regression tests) to now include both "basic" and "dfi". Choose an existing PR, add the label "Feature" to it (that already exists in the list of available labels), and put in some innocuous change to one of the *.F or Registry files that are already being updated. That should trigger a jenkins test with your new DFI restart feature addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new directory contained a restart test for the DFI feature is added.
Directory name: cases/dfi
Variations from "basic" case: