Skip to content

Add test for DFI#2

Merged
davegill merged 2 commits intomainfrom
add_dfi_test
Nov 3, 2021
Merged

Add test for DFI#2
davegill merged 2 commits intomainfrom
add_dfi_test

Conversation

@kkeene44
Copy link
Collaborator

@kkeene44 kkeene44 commented Nov 1, 2021

A new directory contained a restart test for the DFI feature is added.

Directory name: cases/dfi
Variations from "basic" case:

         &dfi_control
           dfi_opt                             = 3,
           dfi_nfilter                         = 7,
           dfi_cutoff_seconds                  = 3600,
           dfi_write_filtered_input            = .true.
           dfi_write_dfi_history               = .false.
           dfi_bckstop_year                    = 2016,
           dfi_bckstop_month                   = 03,
           dfi_bckstop_day                     = 22,
           dfi_bckstop_hour                    = 23,
           dfi_bckstop_minute                  = 00,
           dfi_bckstop_second                  = 00,
           dfi_fwdstop_year                    = 2016,
           dfi_fwdstop_month                   = 03,
           dfi_fwdstop_day                     = 23,
           dfi_fwdstop_hour                    = 00,
           dfi_fwdstop_minute                  = 30,
           dfi_fwdstop_second                  = 00,
         /
  • Requires 1 hour backward and 1 hour forward simulations for DFI in first WRF simulation

@kkeene44 kkeene44 requested a review from davegill November 1, 2021 20:50
@kkeene44
Copy link
Collaborator Author

kkeene44 commented Nov 1, 2021

@davegill
I actually thought that was the case too. I do have it turned off in the restart test for the tests I conduct manually, but tested it this way and still got BFB results, so I wasn't sure. You know DFI better than I do, so if you think it should be off, then it definitely should be.

@davegill
Copy link
Owner

davegill commented Nov 1, 2021

@kkeene44
Kelly,
In the comments section, would you add something that could be a template to follow for your future additions. Such as

1. Directory name: dfi
2. Perturbations from basic:
   . Uses DFI option=3
   . Requires 1 hour backward and 1 hour forward simulations
   . Total time of 2 h 12 min instead of 12 min

You are good at this sort of detailed information. Likely, this will be for your benefit

@davegill
Copy link
Owner

davegill commented Nov 1, 2021

@kkeene44
Kelly,
Riiight, likely the DFI is not "done" on the restart since we start after the initial time. But for clarity, set the dfi_opt=0 (or zap the whole dfi namelist record) on namelist.input.3.

@davegill davegill merged commit 2db0fc5 into main Nov 3, 2021
@davegill
Copy link
Owner

davegill commented Nov 3, 2021

@kkeene44
Kelly,
I updated the wrf-coop repo (which is what runs the regression tests) to now include both "basic" and "dfi". Choose an existing PR, add the label "Feature" to it (that already exists in the list of available labels), and put in some innocuous change to one of the *.F or Registry files that are already being updated. That should trigger a jenkins test with your new DFI restart feature addition.

@kkeene44
Copy link
Collaborator Author

kkeene44 commented Nov 4, 2021

@davegill
Can I do it on your Scala Branch Test PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants