Cake Retarget #95
Merged
Cake Retarget #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just tried to use this and I have realised a couple of other flaws in the original design. The settings are not really settings because well you cannot set them, they are just set to a private property and then passed to the underlying Run method. I am just going to fix that and update the pull request. |
|
You can now set the settings. I have kept the API surface compatible with the old one so no breaking changes. |
|
Awesome, thanks! I'll get this merged and released first thing tomorrow. |
|
Thanks again! So "first thing" got overtaken by the day job, but going to try to get a release out sometime today if I can square away a few other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have change the Cake.Scripty to 4.5. I also updated the README, added syntax highlighting to the code blocks and fixed another issue which tripped me up earlier where the README still referred to the item group "ScriptFile" not "ScriptyFile".
Fixed #94