Add component binding to itself #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! Could you please add this feature to the compatibility list? |
also remove unwanted code
daugeldauge
reviewed
Jan 17, 2023
| @@ -124,6 +128,10 @@ internal fun KSClassDeclaration.asClassName(): ClassName { | |||
| return ClassName(packageNameString, simpleNames) | |||
| } | |||
|
|
|||
| internal fun KSClassDeclaration.asTypeName(): TypeName { | |||
| return asStarProjectedType().asTypeName() | |||
There was a problem hiding this comment.
This extension does something more specific than stated in its name. Maybe replace it with two calls on the usage site?
| internal class ComponentBinding( | ||
| component: KSClassDeclaration, | ||
| ) : Binding { | ||
| override val key = Key(component.asStarProjectedType()) |
There was a problem hiding this comment.
Is there a check that a component can't be a generic class? If not maybe it's worth adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.