Change unescaped characters handling in format, lightFormat and parse (closes #1056)
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parse` 1) Throw RangeError if format string contains an unescaped latin alphabet character; 2) Add new options `useAdditionalWeekYearTokens` and `useAdditionalDayOfYearTokens` for `format` and `parse`. They are permanent API; 3) Remove `awareOfUnicodeTokens` option because it proved to be ineffective.
kossnocorp
requested changes
Jan 31, 2019
There was a problem hiding this comment.
Please update the changelog and prepare an entry for "v2 Pre-Releases Change Log": https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136
kossnocorp
approved these changes
Jan 31, 2019
emilecantin
added a commit
to emilecantin/react-datepicker
that referenced
this pull request
Jan 24, 2024
`awareOfUnicodeTokens` has been removed in date-fns/date-fns#1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useAdditionalWeekYearTokensanduseAdditionalDayOfYearTokensforformatandparse. They are permanent API;awareOfUnicodeTokensoption because it proved to be ineffective.See #1056 issue for reasoning.