Skip to content

Add function for flattening XML content #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Add function for flattening XML content #77

merged 2 commits into from
Dec 2, 2020

Conversation

fugu13
Copy link
Contributor

@fugu13 fugu13 commented Dec 1, 2020 •
edited
Loading

This makes it easy for a user receiving XML content to turn some part (such as mixed content element containing an HTML comment) into a string that can then be put into output.

Resolves #57

@fugu13 fugu13 requested review from jam01 and JakeMHughes December 1, 2020 23:42
jam01
jam01 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jam01 jam01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. I think 'flatten' is correct, but wondering if there's a more expressive name in the context of XML... but flatten is fine with me.

@jam01 jam01 merged commit e631a62 into main Dec 2, 2020
@jam01 jam01 deleted the flatten-function branch December 2, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jam01 jam01 jam01 approved these changes

@JakeMHughes JakeMHughes JakeMHughes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide mixed content flattening function
3 participants
@fugu13 @jam01 @JakeMHughes