Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XML node ordering to be based on ordering keys #73

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Conversation

fugu13
Copy link
Contributor

@fugu13 fugu13 commented Dec 1, 2020

Ordering keys are special keys within elements, and default to use "~". Their value is an integer (which can be a string or a number-as-string). When specified, they will be used for ordering. When not specified, an element's ordering in the original JSON will be used. These two results can be mixed, though results may be unexpected, mostly to support easy copy and paste of sections of JSON.

Resolves #60, resolves #65

…ys are used in objects representing XML elements to indicate precisely where in the order of child nodes within a parent they are.
…ys allow specifying exactly how XML output should be ordered
…tputting numbers instead of strings when reading
@fugu13 fugu13 requested review from jam01 and JakeMHughes December 1, 2020 19:46
Copy link
Contributor

@jam01 jam01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

notes:
remove preserve order
remove some comments already addressed

@fugu13 fugu13 merged commit 12270ae into main Dec 1, 2020
@fugu13 fugu13 deleted the ordering-keys branch December 1, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants