Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-DbaAgentSchedule - fixes issue #5090 and adds test for it #5092

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Get-DbaAgentSchedule - fixes issue #5090 and adds test for it #5092

merged 2 commits into from
Feb 15, 2019

Conversation

jpomfret
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fixes issue #5090 where several properties were null in the output.

Approach

Changed from using input object:

Add-Member -Force -InputObject $schedule -MemberType NoteProperty ComputerName -value $server.ComputerName

to piping:

$schedule | Add-Member -Type NoteProperty -Name ComputerName -Value $server.ComputerName

Commands to test

Screenshots

image

@potatoqualitee potatoqualitee merged commit c7383b7 into dataplat:development Feb 15, 2019
@jpomfret jpomfret deleted the dbaagentschedule branch March 20, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpomfret @potatoqualitee