Fix escaping multibyte strings #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rate() as it is a character number, but we need get a byte number.
Fix utf8 escape
Fix code format
dakulov
changed the title
evgeniy-r
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues and improvements:
Carog update for rust compatibility:
A carog update was performed to resolve a compilation issue under
Rust 1.80.1. The error was caused by thetime v0.3.22library, specifically theError[E0282]: type annotations needed for Box<_>in the filetime-0.3.22/src/format_description/parse/mod.rs:83:9. Please note, I am not a Rust developer, and while the carog update resolved the issue, I am not fully certain this is the most appropriate solution.Docker compose update:
The
docker-composecommand in the demo makefile has been replaced with the recommendeddocker composecommand.Critical bug fix:
Addressed the critical issue reported in issue #218, where, under certain circumstances, escaping a multibyte string could cause a critical error and interrupt the dump creation process.
Tests added:
Added tests to cover two basic scenarios where the aforementioned bug could occur, ensuring the robustness of the fix.